Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typescript with flycheck #2874

Closed
wants to merge 1 commit into from

Conversation

moredhel
Copy link

@moredhel moredhel commented Sep 3, 2015

this aims to replace the use of flymake with flycheck, giving us a consistent fly* package.

@robbyoconnor
Copy link
Contributor

Rebase so it's one single commit ;)

;; URL: https://github.com/syl20bnr/spacemacs
;;
;; This file is not part of GNU Emacs.
;;
;;; License: GPLv3

(setq typescript-packages '(tss))
(setq typescript-private-packages '(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typescript-packages

@moredhel moredhel force-pushed the typescript-with-flycheck branch 3 times, most recently from 244d427 to 52b9252 Compare September 4, 2015 11:17
(use-package tss
:defer t
:mode ("\\.ts\\'" . typescript-mode)
:init (evil-leader/set-key-for-mode 'typescript-mode
:init (evil-leader/set-key-for-mode 'flycheck-mode
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You probably want to use evil-leader/set-key-for-mode 'typescript-mode to keep this from being bound in other filetypes

@moredhel moredhel force-pushed the typescript-with-flycheck branch 2 times, most recently from 6acc830 to 75ebbe8 Compare September 8, 2015 08:46
add hooks for flycheck while stripping out flymake.

As all other packages are written to depend on flycheck, I thought I would strip it out of this package to let us have a consistent interface in all layers.

Add author.

Cleanup of package.el
@swsnr
Copy link
Contributor

swsnr commented Nov 21, 2015

Why not contribute the syntax checker to Flycheck?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants